Check DoNotEvict after filtering evictable pods to ensure termination can complete. #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 7d00e1e 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6203106ef4a6030008a3d54e |
njtran
reviewed
Feb 8, 2022
njtran
reviewed
Feb 9, 2022
| pod := test.Pod(test.PodOptions{ | ||
| NodeName: node.Name, | ||
| ObjectMeta: metav1.ObjectMeta{Annotations: map[string]string{v1alpha5.DoNotEvictPodAnnotationKey: "true"}}, | ||
| }) |
There was a problem hiding this comment.
Consider testing static pods and a pod that tolerates NoSchedule, should just be two more pods creation lines, and adding to the respective lines below.
Co-authored-by: Nick Tran <[email protected]>
njtran
previously approved these changes
Feb 9, 2022
njtran
approved these changes
Feb 9, 2022
AndrewSirenko
added a commit
to AndrewSirenko/karpenter-provider-aws
that referenced
this pull request
Aug 1, 2024
AndrewSirenko
added a commit
to AndrewSirenko/karpenter-provider-aws
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#1166
2. Description of changes:
Previously, the
do-not-evictannotation could block termination logic, even if the node was unreachable. This change modifies thedo-not-evictlogic to only apply to evictable pods. Currently, evictable pods excludeThis means that the
do-not-evictannotation will no longer work for pods in the above categories. Given that we already did not attempt to evict these pods, the semantic holds. However, previously, pods in these categories with thedo-not-evictannotation could block node termination.3. How was this change tested?
Reproduced
Fixed
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.